Fix Ctrl+Insert does not copy the selected text from Command Palette #18483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
Issue-Bug
carlos-zamora
approved these changes
Jan 31, 2025
microsoft-github-policy-service
bot
requested review from
zadjii-msft,
PankajBhojwani,
carlos-zamora,
DHowett and
lhecker
microsoft-github-policy-service
bot
removed
the
Needs-Second
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
DHowett
pushed a commit
that referenced
this pull request
Feb 3, 2025
…18483) Fixes an issue where pressing `CTRL` + `Insert` does not copy text selected in the Command Palette. Instead, it closes it, and any text selected in the pane is copied to the clipboard. Since `Insert` is a virtual key, I address the issue by adding a conditional check for `CTRL` with either `Insert` or `C` (previously, it only checked for `CTRL` with `C`) for the copy action in the Command Palette. ## Validation Steps Performed I followed the reproduction steps and verified that the actual behaviour matched the expected behaviour. All existing tests passed, but no new test was added. Closes #9520 (cherry picked from commit 2e92a15) Service-Card-Id: PVTI_lADOAF3p4s4AxadtzgW9xcU Service-Version: 1.23
DHowett
pushed a commit
that referenced
this pull request
Feb 3, 2025
…18483) Fixes an issue where pressing `CTRL` + `Insert` does not copy text selected in the Command Palette. Instead, it closes it, and any text selected in the pane is copied to the clipboard. Since `Insert` is a virtual key, I address the issue by adding a conditional check for `CTRL` with either `Insert` or `C` (previously, it only checked for `CTRL` with `C`) for the copy action in the Command Palette. ## Validation Steps Performed I followed the reproduction steps and verified that the actual behaviour matched the expected behaviour. All existing tests passed, but no new test was added. Closes #9520 (cherry picked from commit 2e92a15) Service-Card-Id: PVTI_lADOAF3p4s4AmhmQzgW9xcY Service-Version: 1.22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Fixes an issue where pressing
CTRL+Insertdoes not copy text selected in the Command Palette. Instead, it closes it, and any text selected in the pane is copied to the clipboard.References and Relevant Issues
This PR handles issue #9520.
Detailed Description of the Pull Request / Additional comments
Since
Insertis a virtual key, I address the issue by adding a conditional check forCTRLwith eitherInsertorC(previously, it only checked forCTRLwithC) for the copy action in the Command Palette.Validation Steps Performed
I followed the reproduction steps and verified that the actual behaviour matched the expected behaviour. All existing tests passed, but no new test was added.
PR Checklist